fix(cupon): prevent null-date crashes and prefill validity

Co-authored-by: Cursor <cursoragent@cursor.com>

app/DataTables/CuponDataTable.php

@@ -13,7 +13,7 @@ use Yajra\DataTables\Html\Editor\Fields;
 use Yajra\DataTables\Services\DataTable;
 use Illuminate\Support\Facades\Auth;
 use Illuminate\Support\Str;
-
+use Carbon\Carbon;
 
 class CuponDataTable extends DataTable
 {
@@ -37,12 +37,25 @@ class CuponDataTable extends DataTable
                 return '€ ' . number_format($entity->importo, 2, ',', '.');
             })
             ->editColumn('validita_display', function ($entity) {
-                if($entity->validita_da->isSameDay($entity->validita_a)){
-                    return $entity->validita_da->format('d/m/Y');
-                }else{
-                    return $entity->validita_da->format('d/m/Y') . ' - ' . $entity->validita_a->format('d/m/Y');
-                }   
-            })
+                $da = $entity->validita_da;
+                $a = $entity->validita_a;
+
+                if (! $da && ! $a) {
+                    return '—';
+                }
+
+                if ($da && ! $a) {
+                    return $da->format('d/m/Y');
+                }
+
+                if (! $da && $a) {
+                    return $a->format('d/m/Y');
+                }
+
+                return $da->isSameDay($a)
+                    ? $da->format('d/m/Y')
+                    : $da->format('d/m/Y') . ' - ' . $a->format('d/m/Y');
+            })  
             ->addColumn('stato_display', function ($entity) {
                 return view('cupon.stato', ['stato' => $entity->stato]);
             })
@@ -122,8 +135,8 @@ class CuponDataTable extends DataTable
                         Fields\Number::make('importo')->label('Importo')->required(),
                         Fields\Text::make('nominativo')->label('Nominativo')->required(),
                         Fields\Text::make('email')->label('Email'),
-                        Fields\Date::make('validita_da')->label('Validità da')->required(),
-                        Fields\Date::make('validita_a')->label('Validità a')->required(),
+                        Fields\Date::make('validita_da')->label('Validità da')->required()->default(Carbon::now()->format('Y-m-d')),
+                        Fields\Date::make('validita_a')->label('Validità a')->required()->default(Carbon::now()->format('Y-m-d')),
                     ]));
     }
 

app/Http/Controllers/CuponController.php

@@ -207,6 +207,13 @@ class CuponController extends Controller
                     $message = 'Cupon utilizzabile';
                 }
 
+                $validitaDa = $cupon->validita_da;
+                $validitaA = $cupon->validita_a;
+                $oggi = $validitaDa
+                    && $validitaA
+                    && $validitaDa->isSameDay($validitaA)
+                    && $validitaDa->isSameDay(Carbon::today());
+
                 return response()->json([
                     'success'    => $success,
                     'message'    => $message,
@@ -214,7 +221,7 @@ class CuponController extends Controller
                     'nominativo' => $cupon->nominativo,
                     'validita_da' => $cupon->validita_da?->format('d/m/Y'),
                     'validita_a'  => $cupon->validita_a?->format('d/m/Y'),
-                    'oggi' => $oggi = $cupon->validita_da->isSameDay($cupon->validita_a) && $cupon->validita_da->isSameDay(Carbon::today()),
+                    'oggi' => $oggi,
                 ]);
             case Cupon::USATO:
                 return response()->json(['success' => false, 'message' => 'Cupon già utilizzato']);

resources/views/cupon/stato.blade.php

@@ -8,7 +8,7 @@
 @endphp
 
 @if($codice !== '' && $stato === '')
-    <span class="badge bg-body font-monospace fs-6" title="Codice {{ $codice }}">
+    <span class="badge font-monospace fs-6" title="Codice {{ $codice }}">
         {{ $codice }}
     </span>
 @else